Re: [PATCH] selftest: net: fix socklen_t type mismatch in sctp_collision test

From: Ankit Khushwaha

Date: Tue Oct 28 2025 - 13:10:26 EST


On Tue, Oct 28, 2025 at 04:40:58PM +0000, Simon Horman wrote:
> Hi Ankit,
>
> Please preserve reverse xmas tree order - longest line to shortest - for
> local variable declarations in Networking code.
>
> In this case, I think that would be as follows (completely untested).
>
> struct sockaddr_in saddr = {}, daddr = {};
> socklen_t len = sizeof(daddr);
> struct timeval tv = {25, 0};
> char buf[] = "hello";
> int sd, ret;
>
Hi Simon,
Thanks for your reply, i will send v2 patch with requested changes.

--
Ankit