Re: [PATCH v2 2/2] media: chips-media: wave5: Process ready frames when CMD_STOP sent to Encoder

From: Nicolas Dufresne

Date: Tue Oct 28 2025 - 12:44:37 EST


Le mardi 21 octobre 2025 à 15:46 -0500, Brandon Brnich a écrit :
> CMD_STOP being sent to encoder before last job is executed by device_run
> can lead to an occasional dropped frame. Ensure that remaining ready
> buffers are drained by making a call to v4l2_m2m_try_schedule.
>
> Signed-off-by: Brandon Brnich <b-brnich@xxxxxx>

Reviewed-by: Nicolas Dufresne <nicolas.dufresne@xxxxxxxxxxxxx>

> ---
>  drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c
> b/drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c
> index 0a2eab372913..7ee77c9a30c0 100644
> --- a/drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c
> +++ b/drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c
> @@ -649,6 +649,8 @@ static int wave5_vpu_enc_encoder_cmd(struct file *file,
> void *fh, struct v4l2_en
>  
>   m2m_ctx->last_src_buf = v4l2_m2m_last_src_buf(m2m_ctx);
>   m2m_ctx->is_draining = true;
> +
> + v4l2_m2m_try_schedule(m2m_ctx);
>   break;
>   case V4L2_ENC_CMD_START:
>   break;

Attachment: signature.asc
Description: This is a digitally signed message part