Re: [PATCH] usb: typec: ucsi: Skip setting orientation for UCSI version 2.0 and above
From: Abel Vesa
Date: Tue Oct 28 2025 - 11:44:34 EST
On 25-10-28 17:37:45, Abel Vesa wrote:
> On 25-10-28 17:30:37, Dmitry Baryshkov wrote:
> > On Tue, Oct 28, 2025 at 05:19:58PM +0200, Abel Vesa wrote:
> > > On 25-10-28 16:39:19, Abel Vesa wrote:
> > > > In case of UCSI version 2.0 and above, if the orientation is set from
> > > > glink as well, it will trigger the consumers along the graph (PHYs,
> > > > repeaters and so on) to reconfigure a second time. This might break
> > > > the consumer drivers which aren't currently implemented to drop the
> > > > second request of setting the same orientation.
> > > >
> > > > So lets leave the orientation setting to the UCSI generic implementation
> > > > for all platform that implement UCSI spec 2.0 and above.
> > > >
> > > > Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx>
> > >
> > > Ignore this one please, as it is incomplete.
> > >
> > > We need to also set the orientation_aware in pmic_glink_ucsi_update_connector()
> > > if the ucsi version is at least 2.0.
> >
> > Note, I think it should be set in the core rather than setting it in the
> > driver.
>
> Yep. I agree.
>
> That's what I'm doing next.
There you go:
https://lore.kernel.org/r/20251028-b4-ucsi-set-orientation-aware-on-version-2-and-above-v1-1-d3425f5679af@xxxxxxxxxx