Re: [RFT PATCH] xhci: sideband: Fix race condition in sideband unregister

From: Mathias Nyman

Date: Tue Oct 28 2025 - 10:59:23 EST


On 10/28/25 15:56, Greg KH wrote:

@@ -474,16 +494,23 @@ xhci_sideband_unregister(struct xhci_sideband *sb)
xhci = sb->xhci;
mutex_lock(&sb->mutex);
+
+ vdev = sb->vdev;
+ if (!vdev)
+ return;

Lock is still held :(


Oops, missed one

I think you need to use guard() to make this more sane.

Clearly yes, I'll send a v2


thanks,

greg k-h


Thanks
Mathias