Re: [PATCH v3 05/10] rust: uaccess: add UserSliceWriter::write_slice_file()
From: Miguel Ojeda
Date: Tue Oct 28 2025 - 10:08:06 EST
On Wed, Oct 22, 2025 at 4:32 PM Danilo Krummrich <dakr@xxxxxxxxxx> wrote:
>
> + /// Writes raw data to this user pointer from a kernel buffer partially.
We use "user pointer" in a few places (including another of the added
ones), while "user slice" in others -- shouldn't we just use "user
slice"?
By the way, for new APIs with several arguments and potential paths
due to the `offset`, it wouldn't hurt to have an example (even if
build-only) with a couple asserts to show how the API behaves. But I
can create a good first issue for that if you prefer.
Similarly (another potential good first issue), should we use e.g.
#[doc(alias = "simple_read_from_buffer")]`
?
Thanks!
Cheers,
Miguel