Re: [PATCH] net: i825xx: replace printk() with pr_*() macros for cleaner logging

[Andrew Lunn]

On Tue, Oct 28, 2025 at 10:01:27AM +0000, Dharanitharan R wrote:
> This patch replaces printk() calls in sun3_82586.c with appropriate pr_*()
> macros (pr_err, pr_info, etc.) according to Linux kernel logging conventions.

You have a Sun3? I've not seen one in maybe 25 years.

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

says:

1.6.6. Clean-up patches

Netdev discourages patches which perform simple clean-ups, which are
not in the context of other work. For example:

Addressing checkpatch.pl, and other trivial coding style warnings

Addressing Local variable ordering issues

Conversions to device-managed APIs (devm_ helpers)

This is because it is felt that the churn that such changes produce
comes at a greater cost than the value of such clean-ups.

Please state in the commit message if you have run these patches on
hardware, and plan to do other work on the Sun3 driver, new features
etc.

    Andrew

---
pw-bot: cr