Re: [PATCH 1/2] dt-bindings: firmware: Add Agilex5 SVC compatible string

[Krzysztof Kozlowski]

On 28/10/2025 11:59, Romli, Khairul Anuar wrote:
> On 28/10/2025 5:35 pm, Krzysztof Kozlowski wrote:
>> [You don't often get email from krzk@xxxxxxxxxx. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>>
>> On 28/10/2025 10:28, Khairul Anuar Romli wrote:
>>> Enable support for the Agilex5 in Stratix10 SoC service layer (SVC) by
>>> adding the new compatible string "intel,agilex5-svc" in the device tree
>>> bindings.
>>>
>>> This is needed to differentiate Agilex5 from previous SoC generations, as
>>> Agilex5 uses a different mechanism for mapping reserved memory regions,
>>> which rely on IOMMU support.
>>
>> There are no iommus here, so this feels inaccurate.
>>
>> Best regards,
>> Krzysztof
> 
> I will remove this on the v2 revision as the iommu is part on future 
> patch series.
>

No, instead please post complete bindings for this device. So all of the
hardware properties. See writing bindings doc.

Best regards,
Krzysztof