Re: [PATCH 1/3] dt-bindings: media: camss: Add qcom,sm6350-camss

[Krzysztof Kozlowski]

On 28/10/2025 11:24, Bryan O'Donoghue wrote:
> On 28/10/2025 09:46, Krzysztof Kozlowski wrote:
>>>>> +  power-domain-names:
>>>>> +    items:
>>>>> +      - const: ife0
>>>>> +      - const: ife1
>>>>> +      - const: ife2
>>>>> +      - const: top
>>>> Uh, not your fault, but who came with this list in previous generations?
>>>> Instead of simple and obvious "top+ifeX" which allows growing/shrinking,
>>>> someone put "top" at the end which means this cannot follow same order
>>>> as X1E for example... Heh, it follows at least sm8550.
>>> Shall we put top as first power-domain? I don't think it's an issue to
>>> change the order.
>> Well, it matches sm8550, so I am just grumpy complaining. It's fine.
> 
> The provenance here is "top" was required to be added last because the 
> code depended on magic indexing in dtb to know which was the TOP GDSC.


That's silly, because if it was first element would be much easier.

Best regards,
Krzysztof