Re: [PATCH v2 1/3] dt-bindings: phy: qcom-edp: Add edp ref clk for sa8775p

[Ritesh Kumar]

On 10/27/2025 10:35 PM, Bjorn Andersson wrote:
> On Mon, Oct 13, 2025 at 04:18:04PM +0530, Ritesh Kumar wrote:
> > Add edp reference clock for sa8775p edp phy.
>
> Perhaps the eDP ref clock was missed in the initial contribution,
> perhaps it wasn't supposed to be described at the time, perhaps the
> hardware changed...we can only speculate on the purpose of this patch...
>
> You could change this however, by following
> https://docs.kernel.org/process/submitting-patches.html#describe-your-changes
> and start your commit message with an explanation of the problem you're
> trying to solve...

Sure, will update the commit message giving details of the problem.

> > 
> > Signed-off-by: Ritesh Kumar <quic_riteshk@xxxxxxxxxxx>
>
> Please start using your oss.qualcomm.com

Took a note of it.

> Regards,
> Bjorn
>
> > ---
> >  Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
> > index bfc4d75f50ff..b0e4015596de 100644
> > --- a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
> > @@ -73,6 +73,7 @@ allOf:
> >          compatible:
> >            enum:
> >              - qcom,x1e80100-dp-phy
> > +            - qcom,sa8775p-edp-phy
> >      then:
> >        properties:
> >          clocks:
> > -- 
> > 2.17.1
> >