Re: [PATCH v2 2/2] gpio: add gpio-line-mux driver

[Peter Rosin]

Hi!

2025-10-28 at 10:45, Thomas Richard wrote:
> On 10/27/25 12:17 AM, Jonas Jelonek wrote:
>> +	ret = mux_control_select(glm->mux, glm->gpio_mux_states[offset]);
>> +	if (ret < 0)
>> +		return ret;
>> +
>> +	ret = gpiod_get_raw_value_cansleep(glm->shared_gpio);
> 
> Why ignoring ACTIVE_LOW status ?
> And cansleep depends on your shared_gpio line, maybe it is not the case.
> 
>> +	mux_control_deselect(glm->mux);

*snip*

>> +	glm->gc.can_sleep = true;
> 
> depends on your shared_gpio line.

Does it? In this case, the gpio will always need to be able to
sleep, since mux_control_select() may sleep. Or, what am I
missing?

>                                   Use gpiod_cansleep() like in the
> gpio-aggregator driver to know if your shared_gpio can sleep.

Cheers,
Peter