Re: [PATCH v5 1/7] media: platform: amd: Introduce amd isp4 capture driver

[Du, Bin]

Thanks Krzysztof.

On 10/28/2025 4:41 PM, Krzysztof Kozlowski wrote:
> On 28/10/2025 09:30, Du, Bin wrote:
> > > > +	}
> > > > +};
> > > > +
> > > > +module_platform_driver(isp4_capture_drv);
> > > > +
> > > > +MODULE_ALIAS("platform:" ISP4_DRV_NAME);
> > >
> > > You should not need MODULE_ALIAS() in normal cases. If you need it,
> > > usually it means your device ID table is wrong (e.g. misses either
> > > entries or MODULE_DEVICE_TABLE()). MODULE_ALIAS() is not a substitute
> > > for incomplete ID table.
> >
> > Thanks for the clarification, yes, MODULE_ALIAS() does not apply in our
> > case and should be removed.
>
>
> You don't have ID table, so probably this should be fixed, unless it is
> instantiated by some other driver, e.g. as MFD. That's the only typical
> use case for alias in the drivers.

Yes, our device is a MFD, so alias works for it, as alternative, we can 
add module device table, it should work either, could you please 
indicate your preferred option?

> Best regards,
> Krzysztof

--
Regards,
Bin