Re: [PATCH v2 01/26] drm/xe/pf: Remove GuC version check for migration support
From: Winiarski, Michal
Date: Tue Oct 28 2025 - 04:06:09 EST
On Tue, Oct 28, 2025 at 03:33:22AM +0100, Tian, Kevin wrote:
> > From: Winiarski, Michal <michal.winiarski@xxxxxxxxx>
> > Sent: Wednesday, October 22, 2025 6:41 AM
> >
> > static bool pf_check_migration_support(struct xe_gt *gt)
> > {
> > - /* GuC 70.25 with save/restore v2 is required */
> > - xe_gt_assert(gt, GUC_FIRMWARE_VER(>->uc.guc) >=
> > MAKE_GUC_VER(70, 25, 0));
> > -
> > /* XXX: for now this is for feature enabling only */
> > return IS_ENABLED(CONFIG_DRM_XE_DEBUG);
>
> why putting it under a debug option? Now you are sending formal
> series for merge, assuming good quality.
The need for debug option is removed for specific platforms in Patch
24/26, but I will drop it completely in v3.
-Michał