Re: [PATCH] cpufreq: nforce2: fix reference count leak in nforce2

[Viresh Kumar]

On 27-10-25, 23:04, Miaoqian Lin wrote:
> There are two reference count leaks in this driver:
> 
> 1. In nforce2_fsb_read(): pci_get_subsys() increases the reference count
>    of the PCI device, but pci_dev_put() is never called to release it,
>    thus leaking the reference.
> 
> 2. In nforce2_detect_chipset(): pci_get_subsys() gets a reference to the
>    nforce2_dev which is stored in a global variable, but the reference
>    is never released when the module is unloaded.
> 
> Fix both by:
> - Adding pci_dev_put(nforce2_sub5) in nforce2_fsb_read() after reading
>   the configuration.
> - Adding pci_dev_put(nforce2_dev) in nforce2_exit() to release the
>   global device reference.
> 
> Found via static analysis.
> 
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Miaoqian Lin <linmq006@xxxxxxxxx>
> ---
>  drivers/cpufreq/cpufreq-nforce2.c | 3 +++
>  1 file changed, 3 insertions(+)

Applied. Thanks.

-- 
viresh