Re: [PATCH v2 04/15] dt-bindings: mfd: ROHM BD72720

[Linus Walleij]

Hi Matti,

thanks for your patch!

On Mon, Oct 27, 2025 at 12:45 PM Matti Vaittinen
<mazziesaccount@xxxxxxxxx> wrote:

> +  rohm,clkout-open-drain:
> +    description: clk32kout mode. Set to 1 for "open-drain" or 0 for "cmos".
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    minimum: 0
> +    maximum: 1

I think CMOS is the same as "push-pull" ( I could be wrong, but I think I've
seen that before) so I would probably try to use the pin config standard
names as strings here but I'm not sure.

rohm,clkout-bias-open-drain;
rohm,clkout-bias-push-pull;

Mutually exclusive.

Or maybe use the pattern from rohm,pin-dvs0
with string enumerators?

rohm,clkout-bias = "open-drain";
rohm,clkout-bias = "push-pull";

?

> +examples:

Maybe add some of the exotic string options into the example so
people will get it right?

Yours,
Linus Walleij