Re: [PATCH 2/2] gpu: nova: add boot42 support for next-gen GPUs

From: Joel Fernandes

Date: Mon Oct 27 2025 - 17:21:39 EST


On Sat, Oct 25, 2025 at 10:32:35AM -0700, John Hubbard wrote:
> On 10/25/25 3:01 AM, Danilo Krummrich wrote:
> > On Sat Oct 25, 2025 at 2:14 AM CEST, John Hubbard wrote:
> ...> Why open code all of the above in the struct Gpu constructor? This
> could all
> > happen within Spec::new().
> >
>
> OK, yes, that does help avoid cluttering up Gpu::new().

+1.
Also, it bloats up the dev_info! print in Gpu::new() to those.
Spec can encapsulate the boot0 vs boot42 code, and any further changes.

But otherwise, the boot0 vs boot42 code in the patchset look good to me.

thanks,

- Joel