Re: [PATCH] keys: Fix typos in 'struct key_type' function pointer comments
From: Jarkko Sakkinen
Date: Mon Oct 27 2025 - 16:11:10 EST
On Fri, Oct 24, 2025 at 10:29:57PM +0200, Thorsten Blum wrote:
> On 24. Oct 2025, at 21:04, Jarkko Sakkinen wrote:
> > On Thu, Oct 16, 2025 at 02:36:19PM +0200, Thorsten Blum wrote:
> >> s/it/if/ and s/revokation/revocation/
> >> ...
> >
> > The comment is also formatted incorrectly. It should be:
> >
> > /*
> > * Free preparsed match data (optional). This should be supplied if
> > * ->match_preparse() is supplied.
> > */
>
> The other struct fields are all commented with the first sentence
> starting after the '/*'.
>
> I can fix this one trailing '*/' in v2, but the others should probably
> be fixed in a separate patch?
We don't want to batch update to all comments in this file as that e.g.
has more drawbacks than benefits because it increases the probability
of merge conflicts during backports.
I.e.
1. Refine the patch to address the remark that were anyhow modified.
2. Don't update any other comments just for the remark I did.
>
> Thanks,
> Thorsten
>
BR, Jarkko