Re: [PATCH] keys: Annotate struct asymmetric_key_id with __counted_by
From: Jarkko Sakkinen
Date: Mon Oct 27 2025 - 15:58:00 EST
On Thu, Oct 23, 2025 at 07:48:11PM +0200, Thorsten Blum wrote:
> Add the __counted_by() compiler attribute to the flexible array member
> 'data' to improve access bounds-checking via CONFIG_UBSAN_BOUNDS and
> CONFIG_FORTIFY_SOURCE.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>
> ---
> include/keys/asymmetric-type.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/keys/asymmetric-type.h b/include/keys/asymmetric-type.h
> index 69a13e1e5b2e..1b91c8f98688 100644
> --- a/include/keys/asymmetric-type.h
> +++ b/include/keys/asymmetric-type.h
> @@ -49,7 +49,7 @@ enum asymmetric_payload_bits {
> */
> struct asymmetric_key_id {
> unsigned short len;
> - unsigned char data[];
> + unsigned char data[] __counted_by(len);
> };
>
> struct asymmetric_key_ids {
> --
> 2.51.0
>
Reviewed-by: Jarkko Sakkinen <jarkko@xxxxxxxxxx>
BR, Jarkko