Re: [PATCH v3] mm/shmem: fix THP allocation and fallback loop

From: Barry Song

Date: Thu Oct 23 2025 - 20:47:21 EST


> >
> > Answering my own question, the "Link:" above should be
> >
> > Closes:
> > https://lore.kernel.org/linux-mm/CAMgjq7DqgAmj25nDUwwu1U2cSGSn8n4-Hqpgottedy0S6YYeUw@xxxxxxxxxxxxxx/
> >
>
> Thanks for the review. It's reported by and fixed by me, so I didn't
> include an extra Report-By & Closes, I thought that's kind of
> redundant. Do we need that? Maybe Andrew can help add it :) ?

I also think it’s better to use “Closes:”. In that case, we might need
to slightly
adjust the commit log to remove "[1]" here.

" This may result in inserting and returning a folio of the wrong index
and cause data corruption with some userspace workloads [1]."

With that,
Reviewed-by: Barry Song <baohua@xxxxxxxxxx>

Thanks
Barry