Re: [PATCH v4 2/2] watchdog: Add driver for Gunyah Watchdog

[Krzysztof Kozlowski]

On 31/10/2025 11:18, Hrishabh Rajput via B4 Relay wrote:
> +
> +static DEFINE_SIMPLE_DEV_PM_OPS(gunyah_wdt_pm_ops, gunyah_wdt_suspend, gunyah_wdt_resume);
> +
> +static struct platform_driver gunyah_wdt_driver = {
> +	.probe = gunyah_wdt_probe,
> +	.driver = {
> +		.name = "gunyah-wdt",
> +		.pm = pm_sleep_ptr(&gunyah_wdt_pm_ops),
> +	},
> +};
> +
> +static int __init gunyah_wdt_init(void)
> +{
> +	return platform_driver_register(&gunyah_wdt_driver);
> +}
> +
> +module_init(gunyah_wdt_init);


Heh, what was my last message? If I see module_init() I will NAK it.

At v3 you really ignored entire feedback and this one here continues the
pattern.

NAK, please read how Linux driver model is works.

Best regards,
Krzysztof