Re: [PATCH v3] watchdog: Add driver for Gunyah Watchdog

[Krzysztof Kozlowski]

On 28/10/2025 11:58, Hrishabh Rajput wrote:
> 
> On 10/28/2025 3:10 PM, Krzysztof Kozlowski wrote:
>> On 28/10/2025 10:35, Hrishabh Rajput via B4 Relay wrote:
>>> +
>>> +static int __init gunyah_wdt_init(void)
>>> +{
>>> +	struct arm_smccc_res res;
>>> +	struct device_node *np;
>>> +	int ret;
>>> +
>>> +	/* Check if we're running on a Qualcomm device */
>>> +	np = of_find_compatible_node(NULL, NULL, "qcom,smem");
>> I don't think you implemented my feedback. This again is executed on
>> every platform, e.g. on Samsung, pointlessly.
>>
>> Implement previous feedback.
> 
> Do you want us to add platform device from another driver which is 
> probed only on Qualcomm devices (like socinfo from previous discussion) 
> and get rid of the module init function entirely? As keeping anything in 
> the module init will get it executed on all platforms.

Instead of asking the same can you read previous discussion? What is
unclear here:
https://lore.kernel.org/all/3b901f9d-dbfa-4f93-a8d2-3e89bd9783c9@xxxxxxxxxx/
?

> 
> 
> With this patch version, we have tried to reduce the code execution on 
> non-Qualcomm devices (also tried the alternative as mentioned in the 
> cover letter). Adding platform device from another driver as described 
> above would eliminate it entirely, please let us know if you want us to 
> do that.

Why do I need to repeat the same as last time?

Best regards,
Krzysztof