Re: [PATCH v2] staging: sm750fb: style fixes: align call and split chained assignment

From: Greg KH

Date: Wed Oct 29 2025 - 06:16:37 EST


On Wed, Oct 29, 2025 at 03:14:49AM +0100, Cristian Del Gobbo wrote:
> - Drop previous change that made g_fbmode[] elements const (broke build).
> - Align the continued arguments of sm750_hw_cursor_set_size() with the
> opening parenthesis.
> - Replace a chained assignment of red/green/blue with a temporary
> variable to satisfy checkpatch and improve readability.
>
> No functional change intended.
>
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> Signed-off-by: Cristian Del Gobbo <cristiandelgobbo87@xxxxxxxxx>
> ---
> drivers/staging/sm750fb/sm750.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)

On top of what Dan said, I see 4 different copies of this patch in my
inbox, which one is the correct one? Please make it easy for
maintainers to know what patch to review, we get 1000+ emails a day to
deal with and have no short term memory :)

thanks,

greg k-h