Re: [PATCH v4 07/16] mtd: rawnand: sunxi: rework pattern found registers
From: Miquel Raynal
Date: Tue Oct 28 2025 - 12:21:00 EST
On 28/10/2025 at 16:41:48 +01, Jernej Škrabec <jernej.skrabec@xxxxxxxxx> wrote:
> Dne torek, 28. oktober 2025 ob 08:35:00 Srednjeevropski standardni čas je Richard Genoud napisal(a):
>> On H6/H616, the register ECC_PAT_FOUND is at its own address, and not
>> part of ECC status register.
>> So, introduce the pattern found register offset in sunxi_nfc_caps, along
>> with its mask.
>>
>> Also, introduce a non compile-time field_get() because FIELD_GET() and
>> u32_get_bits() don't work with non compile-time constant.
>> https://lore.kernel.org/all/cover.1761588465.git.geert+renesas@xxxxxxxxx
>
> Urls should use Link: tag and be placed at the bottom.
I was about to apply, so I'll fix this while applying.
>
> Code itself looks fine.
Thanks for the review!
Miquèl