Re: [PATCH v10 2/4] PCI/VGA: Replace vga_is_firmware_default() with a screen info check

[Bjorn Helgaas]

On Mon, Oct 13, 2025 at 03:55:31PM -0500, Bjorn Helgaas wrote:
> On Sun, Oct 12, 2025 at 11:23:02AM -0700, Eric Biggers wrote:
> > On Mon, Aug 11, 2025 at 11:26:04AM -0500, Mario Limonciello (AMD) wrote:
> > > vga_is_firmware_default() checks firmware resources to find the owner
> > > framebuffer resources to find the firmware PCI device.  This is an
> > > open coded implementation of screen_info_pci_dev().  Switch to using
> > > screen_info_pci_dev() instead.
> > > 
> > > Acked-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> > > Suggested-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
> > > Signed-off-by: Mario Limonciello (AMD) <superm1@xxxxxxxxxx>
> > 
> > I'm getting a black screen on boot on mainline, and it bisected to this
> > commit.  Reverting this commit fixed it.
> 
> #regzbot introduced: 337bf13aa9dd ("PCI/VGA: Replace vga_is_firmware_default() with a screen info check")
> #regzbot link: https://lore.kernel.org/r/20251013154441.1000875-1-superm1@xxxxxxxxxx

#regzbot fix: a78835b86a44 ("PCI/VGA: Select SCREEN_INFO on X86")