Re: [PATCH] btrfs: make ASSERT no-op in release builds

From: kernel test robot

Date: Fri Oct 31 2025 - 08:19:41 EST


Hi Gladyshev,

kernel test robot noticed the following build warnings:

[auto build test WARNING on e53642b87a4f4b03a8d7e5f8507fc3cd0c595ea6]

url: https://github.com/intel-lab-lkp/linux/commits/Gladyshev-Ilya/btrfs-make-ASSERT-no-op-in-release-builds/20251031-024059
base: e53642b87a4f4b03a8d7e5f8507fc3cd0c595ea6
patch link: https://lore.kernel.org/r/20251030182322.4085697-1-foxido%40foxido.dev
patch subject: [PATCH] btrfs: make ASSERT no-op in release builds
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20251031/202510311956.w2iYoQcn-lkp@xxxxxxxxx/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251031/202510311956.w2iYoQcn-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202510311956.w2iYoQcn-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

>> fs/btrfs/raid56.c:302:13: warning: function 'full_page_sectors_uptodate' is not needed and will not be emitted [-Wunneeded-internal-declaration]
302 | static bool full_page_sectors_uptodate(struct btrfs_raid_bio *rbio,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.


vim +/full_page_sectors_uptodate +302 fs/btrfs/raid56.c

53b381b3abeb86 David Woodhouse 2013-01-29 301
d4e28d9b5f04d8 Qu Wenruo 2022-04-01 @302 static bool full_page_sectors_uptodate(struct btrfs_raid_bio *rbio,
d4e28d9b5f04d8 Qu Wenruo 2022-04-01 303 unsigned int page_nr)
d4e28d9b5f04d8 Qu Wenruo 2022-04-01 304 {
d4e28d9b5f04d8 Qu Wenruo 2022-04-01 305 const u32 sectorsize = rbio->bioc->fs_info->sectorsize;
d4e28d9b5f04d8 Qu Wenruo 2022-04-01 306 const u32 sectors_per_page = PAGE_SIZE / sectorsize;
d4e28d9b5f04d8 Qu Wenruo 2022-04-01 307 int i;
d4e28d9b5f04d8 Qu Wenruo 2022-04-01 308
d4e28d9b5f04d8 Qu Wenruo 2022-04-01 309 ASSERT(page_nr < rbio->nr_pages);
d4e28d9b5f04d8 Qu Wenruo 2022-04-01 310
d4e28d9b5f04d8 Qu Wenruo 2022-04-01 311 for (i = sectors_per_page * page_nr;
d4e28d9b5f04d8 Qu Wenruo 2022-04-01 312 i < sectors_per_page * page_nr + sectors_per_page;
d4e28d9b5f04d8 Qu Wenruo 2022-04-01 313 i++) {
d4e28d9b5f04d8 Qu Wenruo 2022-04-01 314 if (!rbio->stripe_sectors[i].uptodate)
d4e28d9b5f04d8 Qu Wenruo 2022-04-01 315 return false;
d4e28d9b5f04d8 Qu Wenruo 2022-04-01 316 }
d4e28d9b5f04d8 Qu Wenruo 2022-04-01 317 return true;
d4e28d9b5f04d8 Qu Wenruo 2022-04-01 318 }
d4e28d9b5f04d8 Qu Wenruo 2022-04-01 319

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki