Re: [PATCH RESEND] rust: transmute: add `from_bytes_prefix` family of methods
From: Danilo Krummrich
Date: Sat Nov 01 2025 - 09:52:56 EST
On Sat Nov 1, 2025 at 2:41 PM CET, Alexandre Courbot wrote:
> The `from_bytes*` family of functions expect a slice of the exact same
> size as the requested type. This can be sometimes cumbersome for callers
> that deal with dynamic stream of data that needs to be manually cut
> before each invocation of `from_bytes`.
>
> To simplify such callers, introduce a new `from_bytes*_prefix` family of
> methods, which split the input slice at the index required for the
> equivalent `from_bytes` method to succeed, and return its result
> alongside with the remainder of the slice.
>
> This design is inspired by zerocopy's `try_*_from_prefix` family of
> methods.
>
> Signed-off-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
Reviewed-by: Danilo Krummrich <dakr@xxxxxxxxxx>
One nit below:
> + /// Converts the beginning of `bytes` to a reference to `Self`.
> + ///
> + /// This method is similar to [`Self::from_bytes`], with the difference that `bytes` does not
> + /// need to be the same size of `Self` - the appropriate portion is cut from the beginning of
> + /// `bytes`, and the remainder returned alongside the result.
Maybe "alongside `&Self`"? "alongside the result" sounds a bit like the method
would return `Result<&Self>, &[u8]`.