Re: [PATCH 7/9] iio: imu: st_lsm6dsx: make event management functions generic
From: Jonathan Cameron
Date: Sun Nov 02 2025 - 06:33:44 EST
On Thu, 30 Oct 2025 08:27:50 +0100
Francesco Lavra <flavra@xxxxxxxxxxxx> wrote:
> In preparation for adding support for more event types, use an
General comment. Wrap commit descriptions a bit longer. Standard is 75 chars.
This is about 68.
> array indexed by event ID instead of a scalar value to store
> enabled events, and refactor the functions to configure and report
> events so that their implementation is not specific for wakeup
> events. Move the logic to update the global event interrupt enable
> flag from st_lsm6dsx_event_setup() to its calling function, so that
> it can take into account also event sources different from the
> source being configured. While changing the signature of the
> st_lsm6dsx_event_setup() function, opportunistically add the
> currently unused `axis` parameter, which will be used when adding
> support for enabling and disabling events on a per axis basis.
I have nothing to add to Andy's review on the code.