Re: [PATCH v4 1/2] dt-bindings: arm: qcom: Add Lenovo P2
From: Krzysztof Kozlowski
Date: Sun Nov 02 2025 - 11:15:03 EST
On Fri, Oct 31, 2025 at 07:21:20PM +0530, Raihan Ahamed wrote:
> Document the compatible for the MSM8953-based Lenovo P2
>
> smartphone released in 2016
That's one sentence. Sentences also start with a capital letter and end
with full stop. Please write correct sentences (see also submitting
patches).
I already asked for this!
NAK
>
> Signed-off-by: Raihan Ahamed <raihan1999ahamed@xxxxxxxxx>
> ---
> version 4
> - rebased on linux-next
> - enabled accelerometer sensor
> - enabled gpu and add gpu_zap_shader
> - add homescreen and one-key-low-power gpio-keys
> - enabled pinctrl for gpio-keys
> - removed explicily added tag
What? Why? You must explain WHY.
What is happening here? Did you even read what we wrote to you?
>
> version 3
> - sorry for explicitly adding tags
> linked-to v3: https://yhbt.net/lore/linux-devicetree/20240226195516.174737-1-raihan1999ahamed@xxxxxxxxx/
What is this? Please use standard lore links.
Best regards,
Krzysztof