Re: [PATCH net 1/3] net: dsa: b53: fix enabling ip multicast

[Florian Fainelli]

On 11/2/2025 2:07 AM, Jonas Gorski wrote:
> In the New Control register bit 1 is either reserved, or has a different
> function:
>
>      Out of Range Error Discard
>
>      When enabled, the ingress port discards any frames
>      if the Length field is between 1500 and 1536
>      (excluding 1500 and 1536) and with good CRC.
>
> The actual bit for enabling IP multicast is bit 0, which was only
> explicitly enabled for BCM5325 so far.
>
> For older switch chips, this bit defaults to 0, so we want to enable it
> as well, while newer switch chips default to 1, and their documentation
> says "It is illegal to set this bit to zero."

The IP_MC bit is definitively a better name and matches what exists in 
the newer switching IP, it does default to 1 there as well, and it has 
the mention that it is illegal to set to zero (makes you wonder why it 
is exposed then).

> So drop the wrong B53_IPMC_FWD_EN define, enable the IP multicast bit
> also for other switch chips. While at it, rename it to (B53_)IP_MC as
> that is how it is called in Broadcom code.
>
> Fixes: 63cc54a6f073 ("net: dsa: b53: Fix egress flooding settings")
> Signed-off-by: Jonas Gorski <jonas.gorski@xxxxxxxxx>

Reviewed-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>
--
Florian