Re: [PATCH] power: supply: Add SC8541 charger drivers

[Sebastian Reichel]

Hi,

On Mon, Oct 13, 2025 at 04:54:14PM +0800, 1647395606@xxxxxx wrote:
> From: wangwenqiang <wenqiang.wang@xxxxxxxxx>
> 
> The SC8541 is a charger pump from South Chip.
> By adjusting the voltage difference between the input and output terminals,
> it can achieve a maximum charging current of 8A.
> It has been verified that this driver can operate normally on the Qualcomm QCS615 platform.
> 
> Signed-off-by: wangwenqiang <wenqiang.wang@xxxxxxxxx>
> ---

(incomplete review; I think the nice review from Linus is enough
work for now anyways :))

> +#ifdef CONFIG_MTK_CLASS
> +#include "charger_class.h"
> +#endif /*CONFIG_MTK_CLASS*/
> +
> +#ifdef CONFIG_MTK_CHARGER_V4P19
> +#include "mtk_charger_intf.h"
> +#endif /*CONFIG_MTK_CHARGER_V4P19*/
> +
> +#ifdef CONFIG_SOUTHCHIP_DVCHG_CLASS
> +#include "dvchg_class.h"
> +#endif /*CONFIG_SOUTHCHIP_DVCHG_CLASS*/

Drop all of the above and any future usage of the ifdefs. This kind
of stuff is not acceptable upstream.

> +#define SC8541_DRV_VERSION              "1.0.0_G"

Also drop this. Upstream driver can use the kernel version and it
surely shouldn't be printed as an error in the probe routine.

Greetings,

-- Sebastian

Attachment: signature.asc
Description: PGP signature