Re: [PATCH v4 1/2] dt-bindings: PCI: EIC7700: Add Eswin PCIe host controller

[Manivannan Sadhasivam]

On Mon, Nov 03, 2025 at 09:48:02AM +0100, Krzysztof Kozlowski wrote:
> On Thu, Oct 30, 2025 at 04:30:57PM +0800, zhangsenchuan@xxxxxxxxxxxxxxxxxx wrote:
> > From: Senchuan Zhang <zhangsenchuan@xxxxxxxxxxxxxxxxxx>
> > 
> > Add Device Tree binding documentation for the Eswin EIC7700 PCIe
> > controller module, the PCIe controller enables the core to correctly
> > initialize and manage the PCIe bus and connected devices.
> > 
> > Signed-off-by: Yu Ning <ningyu@xxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Yanghui Ou <ouyanghui@xxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Senchuan Zhang <zhangsenchuan@xxxxxxxxxxxxxxxxxx>
> > ---
> >  .../bindings/pci/eswin,eic7700-pcie.yaml      | 166 ++++++++++++++++++
> >  .../bindings/pci/snps,dw-pcie-common.yaml     |   2 +-
> >  2 files changed, 167 insertions(+), 1 deletion(-)
> >  create mode 100644 Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml b/Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml
> > new file mode 100644
> > index 000000000000..e6c05e3a093a
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/pci/eswin,eic7700-pcie.yaml
> > @@ -0,0 +1,166 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/pci/eswin,eic7700-pcie.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Eswin EIC7700 PCIe host controller
> > +
> > +maintainers:
> > +  - Yu Ning <ningyu@xxxxxxxxxxxxxxxxxx>
> > +  - Senchuan Zhang <zhangsenchuan@xxxxxxxxxxxxxxxxxx>
> > +  - Yanghui Ou <ouyanghui@xxxxxxxxxxxxxxxxxx>
> > +
> > +description:
> > +  The PCIe controller on EIC7700 SoC.
> > +
> > +properties:
> > +  compatible:
> > +    const: eswin,eic7700-pcie
> > +
> > +  reg:
> > +    maxItems: 3
> > +
> > +  reg-names:
> > +    items:
> > +      - const: dbi
> > +      - const: config
> > +      - const: mgmt
> 
> That's deprecated. Read its description. That's just elbi.
> 
> > +
> > +  ranges:
> > +    maxItems: 3
> > +
> > +  '#interrupt-cells':
> > +    const: 1
> > +
> > +  interrupt-names:
> > +    items:
> > +      - const: msi
> > +      - const: inta
> > +      - const: intb
> > +      - const: intc
> > +      - const: intd
> 
> Thse are legacy signals. Why are you using legacy?
> 

Why not? These INTx signals are still supported by many host platforms/devices.
These are not individual out-of-band signals, but just in-band messages. It is
perfectly fine for a host controller to support them.

- Mani

-- 
மணிவண்ணன் சதாசிவம்