Re: [PATCH 01/19] mm/swap: rename __read_swap_cache_async to swap_cache_alloc_folio

From: Barry Song
Date: Mon Nov 03 2025 - 04:10:55 EST


> > I assume you mean avoiding any mention of swap-out? As for swap-out, we’re
> > swapping a folio out from the LRU — we’re not allocating a new folio.
> >
> > BTW, this sentence also feels a bit odd to me. I’d prefer removing
> > “swap out” from
> > “doing IO (swap in or swap out)”.
>
> How about "doing IO (e.g. swap in or zswap writeback)"? Swap-in is a
> very common user, and zswap writeback can be mentioned explicitly.

Yes, that seems much better. Though Yosry seems to view zswap_writeback as a
swap-in from zswap followed by a swap-out to the device, I kind of
agree with him :-)

Mentioning the special case separately seems to be the clearest approach.

Thanks
Barry