Re: [PATCH v3 01/25] interconnect: qcom: icc-rpmh: convert link_nodes to dynamic array

[Konrad Dybcio]

On 10/31/25 3:45 PM, Dmitry Baryshkov wrote:
> Declaring link_nodes as a double-pointer results in a syntax sugar in
> the interconnect driver to typecast the array. Change the type of
> link_nodes field to the array to remove the need for the extra typecast.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
> ---

[...]

>  static struct qcom_icc_bcm bcm_acv = {
> diff --git a/drivers/interconnect/qcom/icc-rpmh.h b/drivers/interconnect/qcom/icc-rpmh.h
> index 307f48412563690049e944907bd80500f263f738..b72939cceba38e92154f6af5a93149337fa13479 100644
> --- a/drivers/interconnect/qcom/icc-rpmh.h
> +++ b/drivers/interconnect/qcom/icc-rpmh.h
> @@ -98,7 +98,6 @@ struct qcom_icc_node {
>  	const char *name;
>  	u16 links[MAX_LINKS];
>  	u16 id;
> -	struct qcom_icc_node **link_nodes;
>  	struct icc_node *node;
>  	u16 num_links;
>  	u16 channels;
> @@ -108,6 +107,7 @@ struct qcom_icc_node {
>  	struct qcom_icc_bcm *bcms[MAX_BCM_PER_NODE];
>  	size_t num_bcms;
>  	const struct qcom_icc_qosbox *qosbox;
> +	struct qcom_icc_node *link_nodes[];

__counted_by(num_links);

Konrad