Re: [PATCH 2/3] drm/i915: replace use of system_wq with system_percpu_wq

From: Krzysztof Karas
Date: Mon Nov 03 2025 - 05:32:05 EST


Hi Marco,

you could be a bit more specific with your patch title:
"replace use of system_wq with system_percpu_wq in the documentation",
so that it is clear there are no functional changes.

> Currently if a user enqueue a work item using schedule_delayed_work() the
> used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use
> WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to
> schedule_work() that is using system_wq and queue_work(), that makes use
> again of WORK_CPU_UNBOUND.
>
> This lack of consistency cannot be addressed without refactoring the API.
>
> system_wq should be the per-cpu workqueue, yet in this name nothing makes
> that clear, so replace system_wq with system_percpu_wq.
>
> The old wq (system_wq) will be kept for a few release cycles.
>
> Suggested-by: Tejun Heo <tj@xxxxxxxxxx>
> Signed-off-by: Marco Crivellari <marco.crivellari@xxxxxxxx>
> ---

[...]

--
Best Regards,
Krzysztof