Re: [PATCH v4 03/10] software node: allow referencing firmware nodes

[Sakari Ailus]

Hi Bartosz, Andy,

On Mon, Nov 03, 2025 at 11:36:36AM +0100, Bartosz Golaszewski wrote:
> On Mon, Nov 3, 2025 at 10:49 AM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > > +#define SOFTWARE_NODE_REF_SWNODE(_ref, ...)                  \
> > > +     __SOFTWARE_NODE_REF(_ref, __VA_ARGS__)
> > > +
> > > +#define SOFTWARE_NODE_REF_FWNODE(_ref, ...)                  \
> > > +     __SOFTWARE_NODE_REF(_ref, __VA_ARGS__)
> > > +
> > > +/* DEPRECATED, use SOFTWARE_NODE_REF_SWNODE() instead. */
> > > +#define SOFTWARE_NODE_REFERENCE(_ref, ...)                   \
> > > +     SOFTWARE_NODE_REF_SWNODE(_ref, __VA_ARGS__)
> >
> > Now, useless.
> >
> 
> No, why? With these changes, SOFTWARE_NODE_REFERENCE()'s name is a bit
> misleading or incomplete, so I'm proposing to start replacing it with
> SOFTWARE_NODE_REF_SWNODE() which is compatible with the former but has
> a better name.

Given we're already using _Generic() to determine the argument type, could
we simply use e.g. SOFTWARE_NODE_REF() in both cases?

-- 
Kind regards,

Sakari Ailus