Re: [PATCH v4 04/10] gpio: swnode: don't use the swnode's name as the key for GPIO lookup
From: Bartosz Golaszewski
Date: Mon Nov 03 2025 - 05:53:37 EST
On Mon, Nov 3, 2025 at 10:51 AM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> On Mon, Nov 03, 2025 at 10:35:24AM +0100, Bartosz Golaszewski wrote:
> >
> > Looking up a GPIO controller by label that is the name of the software
> > node is wonky at best - the GPIO controller driver is free to set
> > a different label than the name of its firmware node. We're already being
> > passed a firmware node handle attached to the GPIO device to
> > swnode_get_gpio_device() so use it instead for a more precise lookup.
>
> Sounds to me like a ready-to-go patch and even maybe with a Fixes tags, but
> it's up to you. So, why not apply it so we have less churn in the next version
> of the series?
>
Yeah, makes sense.
Fixes: e7f9ff5dc90c ("gpiolib: add support for software nodes")