Re: [PATCH] mei: bus: Add newline to sysfs attribute outputs

[Zhongqiu Han]

On 11/3/2025 8:25 AM, Greg KH wrote:
> On Thu, Oct 30, 2025 at 09:11:34PM +0800, Zhongqiu Han wrote:
> > On 10/30/2025 8:32 PM, Greg KH wrote:
> > > On Thu, Oct 30, 2025 at 08:30:00PM +0800, Zhongqiu Han wrote:
> > > > Append newline characters to sysfs_emit() outputs in func max_conn_show(),
> > > > fixed_show(), and vtag_show(). This aligns with common kernel conventions
> > > > and improves readability for userspace tools that expect
> > > > newline-terminated values.
> > >
> > > What userspace tool reads these values today?  Will this user/kernel api
> > > break them?  How was this tested?
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > Hi Greg,
> > Thanks for your review~
> >
> > Apologies for the confusion in the commit message — there isn't
> > actually a userspace tool that depends on the newline in this case. I
> > just made the change to follow common sysfs formatting practices and
> > improve consistency.
>
> That's fine, but please work with the people that wrote the tools that
> depend on these files today to verify it will not break anything, and
> then resubmit the patch with that information in the changelog.
>
> thanks,
>
> greg k-h

Hi Greg,

Thank you for your feedback. I’m happy to work on this, but I’m
currently not aware of any userspace tools that depend on these sysfs
interfaces, so I can’t confirm the impact right now. I will check and
monitor it and make sure to verify before next resubmitting.


--
Thx and BRs,
Zhongqiu Han