Re: [PATCH net-next V2 7/7] net/mlx5e: Defer channels closure to reduce interface down time
From: Simon Horman
Date: Mon Nov 03 2025 - 09:08:21 EST
On Thu, Oct 30, 2025 at 03:32:39PM +0200, Tariq Toukan wrote:
> Cap bit tis_tir_td_order=1 indicates that an old firmware requirement /
> limitation no longer exists. When unset, the latency of several firmware
> commands significantly increases with the presence of high number of
> co-existing channels (both old and new sets). Hence, we used to close
> unneeded old channels before invoking those firmware commands.
>
> Today, on capable devices, this is no longer the case. Minimize the
> interface down time by deferring the old channels closure, after the
> activation of the new ones.
>
> Perf numbers:
> Measured the number of dropped packets in a simple ping flood test,
> during a configuration change operation, that switches the number of
> channels from 247 to 248.
>
> Before: 71 packets lost
> After: 15 packets lost, ~80% saving.
>
> Signed-off-by: Tariq Toukan <tariqt@xxxxxxxxxx>
> Reviewed-by: Carolina Jubran <cjubran@xxxxxxxxxx>
Reviewed-by: Simon Horman <horms@xxxxxxxxxx>