Re: [PATCH net v3] net: spacemit: Check netif_running() in emac_set_pauseparam()

From: Andrew Lunn
Date: Mon Nov 03 2025 - 10:31:27 EST


On Mon, Nov 03, 2025 at 10:02:49AM +0800, Vivian Wang wrote:
> Currently, emac_set_pauseparam() will oops if userspace calls it while
> the interface is not up, because phydev is NULL, but it is still
> accessed in emac_set_fc() and emac_set_fc_autoneg().
>
> Check for netif_running(dev) in emac_set_pauseparam() before proceeding.
>
> Fixes: bfec6d7f2001 ("net: spacemit: Add K1 Ethernet MAC")
> Signed-off-by: Vivian Wang <wangruikang@xxxxxxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Andrew