Re: [PATCH v2 0/2] reset: handle RESET_GPIO better to provide the fallback

From: Wolfram Sang
Date: Mon Nov 03 2025 - 10:36:55 EST



> You removed RFC and entire rationale. Your earlier commit - 690de2902dca
> - is broken. You must not do that.

Wojciech was told to do exactly what he did. Dunno by whom, I trusted
that after seeing the handling code in reset core. Is the required
fallback documented somewhere?

> Broken 690de2902dca leads to this broken patchset, but that is not a
> correct fix. You need to fix the source - revert 690de2902dca, because
> it is obviously wrong. You MUST ave fallback to reset-gpios, that was
> the entire concept how this driver was written.

What is the benefit of having reset-gpios handling in the reset core
optionally and required as a fallback?

What is the drawback of having this tiny driver in the core and provide
the core-based reset-gpios handling as a way to prevent open coded
solutions?

Sure, I can revert the changes to avoid problems for users, and will
probably do so, but it still feels all very strange to me.

Attachment: signature.asc
Description: PGP signature