Re: [PATCH 1/2] dt-bindings: hwmon: temperature: add support for EMC1812

[Marius.Cristea]

Hi Conor,

On Wed, 2025-10-29 at 18:25 +0000, Conor Dooley wrote:
> On Wed, Oct 29, 2025 at 05:50:58PM +0200, Marius Cristea wrote:
> > This is the devicetree schema for Microchip EMC1812/13/14/15/33
> > Multichannel Low-Voltage Remote Diode Sensor Family.
> > 
> > Signed-off-by: Marius Cristea <marius.cristea@xxxxxxxxxxxxx>
> > ---
> >  .../bindings/hwmon/microchip,emc1812.yaml          | 176
> > +++++++++++++++++++++
> >  MAINTAINERS                                        |   6 +
> >  2 files changed, 182 insertions(+)
> > 
> 

...
> You should be able to just move this into interrupts:
>   interrupts:
>     items:
>       - description:
>           alert-therm2 asserts when a diode temperature exceeds the
> ALERT
>           threshold.
>       - description:
>           therm-addr asserts low when the hardware-set THERM limit
> threshold is
>           exceeded by one of the temperature sensors.
> 
> > +    items:
> > +      - const: alert-therm2
> > +      - const: therm-addr
> 
> Also, should this and interrupts have minItems: 1? Are both actually
> required? Can you have therm-addr without alert-therm2?
> 

Right now the driver doesn't support any interrupts, but it may support
in future. The "alert-therm2" is a maskable interrupt and the "therm-
addr" can't be masked and is "always enabled" into the chip.

I didn't use "minItems: 1" because I wanted to leave to the user the
decision if he needs any interrupts into their system


> pw-bot: changes-requested
> 
> Cheers,
> Conor.
> 
> > +
> > +  "#address-cells":
> > +    const: 1
> > +
> > +  "#size-cells":
> > +    const: 0
> > +

Thanks,
Marius