Re: [PATCH v8 2/3] firmware: qcom_scm: Support multiple waitq contexts

[Bartosz Golaszewski]

On Mon, Nov 3, 2025 at 5:16 PM Shivendra Pratap
<shivendra.pratap@xxxxxxxxxxxxxxxx> wrote:
>
> >> diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c
> >> index 28979f95e51fbee94b84c1570a4d88a76f72db4e..0b6efa7c2bdc25a3ba152c25d5451d1154779ddd 100644
> >> --- a/drivers/firmware/qcom/qcom_scm.c
> >> +++ b/drivers/firmware/qcom/qcom_scm.c
> >> @@ -47,7 +47,7 @@ struct qcom_scm {
> >>         struct clk *iface_clk;
> >>         struct clk *bus_clk;
> >>         struct icc_path *path;
> >> -       struct completion waitq_comp;
> >> +       struct completion *waitq;
> >
> > Why this change? This makes the name less descriptive if not misleading.
>
> Want to make it dynamic array of waitq`s. Should the name be kept as
> struct completion *waitq_comp; ?
>

Yeah, can me waitq_comps if it's plural.

Bart