Re: [PATCH v4 2/2] arm64: dts: qcom: msm8953-lenovo-kuntao: Add initial device tree

[David Heidelberg]

On 31/10/2025 14:51, Raihan Ahamed wrote:
> Lenovo P2 is a handset using the MSM8953 SoC released in 2016
>
> Add a device tree with initial support for:
>
> - Enable accelerometer sensor
> - Enable pinctrl for GPIO keys
> - Enable gpu and add gpu_zap_shader
> - GPIO keys
> - SDHCI (internal and external storage)
> - USB Device Mode
> - WCNSS (WiFi/BT)
> - Regulators
>
> Signed-off-by: Raihan Ahamed <raihan1999ahamed@xxxxxxxxx>
> ---
> version 4
> - rebased on linux-next
> - enabled accelerometer sensor
> - enabled gpu and add gpu_zap_shader
> - add homescreen and one-key-low-power gpio-keys
> - enabled pinctrl for gpio-keys
> - removed explicily added tag
>
> version 3
> - sorry for explicitly adding tags
> linked-to v3: https://yhbt.net/lore/linux-devicetree/20240226195516.174737-1-raihan1999ahamed@xxxxxxxxx/
>
> version 2
> - document device compatible
> linked-to v2: https://yhbt.net/lore/linux-devicetree/20240226094256.5736-1-raihan1999ahamed@xxxxxxxxx/
>
> version 1
> - add initial device tree support
> linked-to v1: https://yhbt.net/lore/linux-devicetree/20240226055615.79195-1-raihan1999ahamed@xxxxxxxxx/

I would recommend to use b4 tool, it'll make your life easier =)

>   arch/arm64/boot/dts/qcom/Makefile             |   1 +
>   .../boot/dts/qcom/msm8953-lenovo-kuntao.dts   | 294 ++++++++++++++++++
>   2 files changed, 295 insertions(+)
>   create mode 100644 arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dts

[...]


> +
> +&gpu_zap_shader {
> +	firmware-name = "qcom/msm8953/lenovo/kuntao/a506_zap.mbn";

Vendor should start with uppercase, so Lenovo instead of lenovo.

Thank you for your effort!
David

> +};
> +
> +&hsusb_phy {
> +	vdd-supply = <&pm8953_l3>;
> +	vdda-pll-supply = <&pm8953_l7>;
> +	vdda-phy-dpdm-supply = <&pm8953_l13>;
> +
> +	status = "okay";
> +};
[...]