Re: [PATCH] i3c: dw: Add apb reset support

[Conor Dooley]

On Mon, Nov 03, 2025 at 10:44:04AM -0500, Frank Li wrote:
> On Sun, Nov 02, 2025 at 06:02:37PM +0800, Jisheng Zhang wrote:
> > Add support of apb reset which is to reset the APB interface.
> >
> > Signed-off-by: Jisheng Zhang <jszhang@xxxxxxxxxx>
> > ---
> >  drivers/i3c/master/dw-i3c-master.c | 9 +++++++++
> >  drivers/i3c/master/dw-i3c-master.h | 1 +
> >  2 files changed, 10 insertions(+)
> >
> > diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
> > index 9ceedf09c3b6..ca2863d2b2b7 100644
> > --- a/drivers/i3c/master/dw-i3c-master.c
> > +++ b/drivers/i3c/master/dw-i3c-master.c
> > @@ -1558,7 +1558,13 @@ int dw_i3c_common_probe(struct dw_i3c_master *master,
> >  	if (IS_ERR(master->core_rst))
> >  		return PTR_ERR(master->core_rst);
> >
> > +	master->apb_rst = devm_reset_control_get_optional_exclusive(&pdev->dev,
> > +								    "apb_rst");
> 
> Does binding already add "app_rst"?  The name "app" should be enough.

The binding defines no resets at all, so there's a missing patch here.

Attachment: signature.asc
Description: PGP signature