[PATCH net-next v3 1/4] dt-bindings: net: ftgmac100: Add delay properties for AST2600

[Jacky Chou]

Hi Andrew,

Thank you for your reply.

> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: aspeed,ast2600-mac01
> > +    then:
> > +      properties:
> > +        rx-internal-delay-ps:
> > +          minimum: 0
> > +          maximum: 1395
> > +          multipleOf: 45
> 
> I would add a default: 0
> 

Agreed.
I will add it in next version.

> > +        tx-internal-delay-ps:
> > +          minimum: 0
> > +          maximum: 1395
> > +          multipleOf: 45
> 
> and also here.
> 

Agreed.

> > +      required:
> > +        - scu
> > +        - rx-internal-delay-ps
> > +        - tx-internal-delay-ps
> 
> and then these are not required, but optional.
> 

Configure the tx/rx delay in the scu register.
At least, the scu handle must be required.

Here I have one question.
In v3 patches series, if the ftgmac driver cannot find one of 
tx-internal-delay-ps and rx-internal-delay-ps, it will return error in probe 
stage.
If here is optional, does it means that just add warning and not return error when
lack one of them and use the default to configure? Or not configure tx/rx delay just
return success in probe stage?

Thanks,
Jacky