Re: [PATCH] dt-bindings: mfd: qcom,tcsr: Add compatible for Kaanapali

[Jingyi Wang]

On 11/4/2025 12:02 PM, Bjorn Andersson wrote:
> On Tue, Nov 04, 2025 at 11:34:25AM +0800, Aiqun(Maria) Yu wrote:
>> On 9/25/2025 7:23 AM, Jingyi Wang wrote:
>>> Document the qcom,tcsr-kaanapali compatible, tcsr will provide various
>>> control and status functions for their peripherals.
>>>
>>> Signed-off-by: Jingyi Wang <jingyi.wang@xxxxxxxxxxxxxxxx>
>>> ---
>>>  Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
>>> index 14ae3f00ef7e..ae55b0a70766 100644
>>> --- a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
>>> +++ b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
>>> @@ -48,6 +48,7 @@ properties:
>>>            - qcom,tcsr-ipq8064
>>>            - qcom,tcsr-ipq8074
>>>            - qcom,tcsr-ipq9574
>>> +          - qcom,tcsr-kaanapali
>>
>> It looks good to me. Glymur didn't have this functionality verified yet.
> 
> You spelled Reviewed-by: Aiqun Yu <..> wrong.
> 
>> Remind for review.
> 
> No need for that, reviewers will review when they have time.
> 
>>

Hi Bjorn,

> 
> But that said, most modern additions to this binding follow the common
> format of qcom,<soc>-<block>.
> 
> So I would prefer this to be qcom,kaanapali-tcsr.
> 
> Regards,
> Bjorn
> 

qcom,tcsr-kaanapali is used to distinguish with binding for GCC:
https://lore.kernel.org/all/20251030-gcc_kaanapali-v2-v2-2-a774a587af6f@xxxxxxxxxxxxxxxx/

Thanks,
Jingyi

>>>            - qcom,tcsr-mdm9615
>>>            - qcom,tcsr-msm8226
>>>            - qcom,tcsr-msm8660
>>>
>>> ---
>>> base-commit: ae2d20002576d2893ecaff25db3d7ef9190ac0b6
>>> change-id: 20250917-knp-mfd-4dd3c81e6b9b
>>>
>>> Best regards,
>>
>>
>> -- 
>> Thx and BRs,
>> Aiqun(Maria) Yu