Re: [PATCH v2 3/5] media: qcom: iris: Add rotation support for encoder

[Wangao Wang]

On 10/31/2025 7:30 PM, Neil Armstrong wrote:
> I found the issue with SM8650, you did not update the vppu33 variant of 
> iris_vpu_enc_line_size.
>
> With this:
> ============================><=============================
> diff --git a/drivers/media/platform/qcom/iris/iris_vpu_buffer.c b/ 
> drivers/media/platform/qcom/iris/iris_vpu_buffer.c
> index be8b8588a39f..4a4fbcbfdb46 100644
> --- a/drivers/media/platform/qcom/iris/iris_vpu_buffer.c
> +++ b/drivers/media/platform/qcom/iris/iris_vpu_buffer.c
> @@ -1082,8 +1082,8 @@ static u32 iris_vpu33_enc_line_size(struct 
> iris_inst *inst)
>   {
>          u32 num_vpp_pipes = inst->core->iris_platform_data->num_vpp_pipe;
>          struct v4l2_format *f = inst->fmt_dst;
> -       u32 height = f->fmt.pix_mp.height;
> -       u32 width = f->fmt.pix_mp.width;
> +       u32 height = iris_vpu_enc_get_bitstream_height(inst);
> +       u32 width = iris_vpu_enc_get_bitstream_width(inst);
>          u32 lcu_size = 16;
>
>          if (inst->codec == V4L2_PIX_FMT_HEVC) {
> ============================><=============================
>
> Tested-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx> # on SM8650-HDK
>
> Neil
>
>
> <snip>
Thank you for helping test on SM8650.
I indeed forgot to add the corresponding changes here.
This issue will be addressed in v3.

--
Best Regards,
Wangao