Re: [PATCH v3 06/20] dt-bindings: mfd: samsung,s2mpg10: Add s2mpg11-pmic
From: Krzysztof Kozlowski
Date: Tue Nov 04 2025 - 03:44:59 EST
On Mon, Nov 03, 2025 at 07:14:45PM +0000, André Draszik wrote:
> + "^vinb[abd]-supply$":
> + description: |
> + Phandle to the power supply for the additional buck rails of the S2MPG11
> + PMIC. The mapping of supply to rail is as follows::
> + vinba - bucka
> + vinbb - buck boost
> + vinbd - buckd
> +
> + "^vinl[1-6]s-supply$":
> + description: |
> + Phandle to the power supply for one or multiple LDO rails of the S2MPG11
> + PMIC. The mapping of supply to rail(s) is as follows:
> + vinl1s - ldo1s, ldo2s
> + vinl2s - ldo8s, ldo9s
> + vinl3s - ldo3s, ldo5s, ldo7s, ldo15s
> + vinl4s - ldo10s, ldo11s, ldo12s, ldo14s
> + vinl5s - ldo4s, ldo6s
> + vinl6s - ldo13s
> +
> required:
> - compatible
> - interrupts
> @@ -81,3 +102,23 @@ allOf:
> properties:
> regulators:
> $ref: /schemas/regulator/samsung,s2mpg10-regulator.yaml
> +
> + patternProperties:
> + "[^m]-supply$": false
> +
> + - if:
OK, so this explains why earlier you put $ref in if:then:. I propose to
move it to separate new MFD schema, because half or more of properties
are not applicable between each of the devices.
Best regards,
Krzysztof