Re: [PATCH v3 11/20] regulator: s2mps11: drop two needless variable initialisations

From: Krzysztof Kozlowski
Date: Tue Nov 04 2025 - 03:49:12 EST


On 03/11/2025 20:14, André Draszik wrote:
> The initialisations being removed are needless, as both variables are
> being assigned values unconditionally further down. Additionally, doing
> this eager init here might lead to preventing the compiler from issuing
> a warning if a future code change actually forgets to assign a useful
> value in some code path.
>
> Signed-off-by: André Draszik <andre.draszik@xxxxxxxxxx>
> ---
> drivers/regulator/s2mps11.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>



Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof