Re: [PATCH v3 12/20] regulator: s2mps11: use dev_err_probe() where appropriate

From: Krzysztof Kozlowski
Date: Tue Nov 04 2025 - 03:51:32 EST


On 03/11/2025 20:14, André Draszik wrote:
> dev_err_probe() exists to simplify code and harmonise error messages,
> there's no reason not to use it here.
>
> While at it, harmonise some error messages to add regulator name and ID
> like in other messages in this driver, and update messages to be more
> similar to other child-drivers of this PMIC (e.g. RTC).
>
> Signed-off-by: André Draszik <andre.draszik@xxxxxxxxxx>
> ---
> drivers/regulator/s2mps11.c | 29 ++++++++++++++---------------
> 1 file changed, 14 insertions(+), 15 deletions(-)



Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof