Re: [PATCH v1 1/1] base64: Unroll the tables initialisers
From: Andy Shevchenko
Date: Tue Nov 04 2025 - 04:47:16 EST
On Tue, Nov 04, 2025 at 09:07:40AM +0000, David Laight wrote:
> On Tue, 4 Nov 2025 10:18:39 +0200
> Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > On Mon, Nov 03, 2025 at 10:18:57PM +0000, David Laight wrote:
...
> > > > + [BASE64_STD] = {
> > > > + 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, /* 0 - 7 */
> > >
> > > You need to use -1 not 0xff.
> >
> > Whu? The s8 type is pretty much 8-bit, care to explain the point?
>
> I think it is clang that complains that the value is out of range.
I use clang on daily basis to compile kernel and I definitely compiled
the proposal I sent. So, no, not this one.
--
With Best Regards,
Andy Shevchenko